-
-
Notifications
You must be signed in to change notification settings - Fork 16
remove reference to value/error when unwrapping outcome, and add .peek() method
#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
graingert
wants to merge
15
commits into
python-trio:main
Choose a base branch
from
graingert:invalid-objects-on-unwrap
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
08b08df
remove instances from outcome on unwrap
graingert 4d40df0
yapf
graingert e0f3178
no need to delete v in unwrap/_unwrap_error
graingert 6f2fe68
replace <DEAD> with <AlreadyUsed>
graingert 2606efb
make error and value private fields accessed by properties
graingert a28ec1a
Revert "make error and value private fields accessed by properties"
graingert fdbd48d
make error and value private fields accessed by properties attempt 2
graingert c73c831
Update src/outcome/_impl.py
graingert bb7e107
add .peek()
graingert b30cc2b
add newsfragment
graingert f863df4
Apply suggestion from @graingert
graingert 28fecf4
yapf
graingert 4322626
Error.peek() raises a copy of the wrapped error
graingert 18a2d77
move attr docstrings to properties
graingert 9fbf914
dedupe AlreadyUsedError code, using the properties
graingert File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.