Warn on ExceptionGroup subclasses without a .derive() method#448
Merged
Zac-HD merged 4 commits intopython-trio:mainfrom Apr 22, 2026
Merged
Warn on ExceptionGroup subclasses without a .derive() method#448Zac-HD merged 4 commits intopython-trio:mainfrom
ExceptionGroup subclasses without a .derive() method#448Zac-HD merged 4 commits intopython-trio:mainfrom
Conversation
Warn when a class inherits from `ExceptionGroup` / `BaseExceptionGroup` but doesn't override `derive`. Without that override, `split`/`subgroup` (as used by nursery and TaskGroup implementations) silently produce plain `ExceptionGroup` instances instead of the custom subclass. Fixes python-trio#334.
Zac-HD
force-pushed
the
claude/fix-flake8-async-334-opeLM
branch
from
28ab3a8 to
574638f
Compare
for more information, see https://pre-commit.ci
`trio.aclose_forcefully` (and `anyio.aclose_forcefully`) are designed specifically for cleanup and cancel immediately by design, so calling them in a `finally:` / critical `except:` does not introduce the cancellation-replacing hazard that ASYNC102 targets. Treat them as safe, same as `.aclose()` with no arguments. Fixes python-trio#446.
The pre-commit ruff/black formatter wrapped some `class Foo(Bar):` lines across multiple lines, which moved the trailing `# error:` annotation off the line where the visitor actually emits the error (the `class` keyword line). Use shorter class names so the formatter leaves them on a single line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn when a class inherits from
ExceptionGroup/BaseExceptionGroupbut doesn't overridederive. Without that override,split/subgroup(as used by nursery and TaskGroup implementations) silently produce plainExceptionGroupinstances instead of the custom subclass. Fixes #334.Also fixes #446.