You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The idea is to fall into infinite cycle until connection is re-established and command retried and executed successfully. For write operations retrying isn't performed and exceptions propagated, but connection is refreshed to be successful during the subsequent calls.
hi, thanks for your contribution, and sorry for not looking at this earlier. (other priorities in life.)
in general, i like the idea behind this pr, but i have some doubts about this implementation. some remarks:
in general subclasses make me sad...
this code uses a TClient subclass. that class is not from happybase but from thrifty, and this code pokes into its internals to override some behaviour. i can't say i like that.
there must be a better way. i strongly favour composition over inheritance, and i think that is the way to go here: encapsulate the thriftpy.TClient and add behaviour in our own class, then delegate to the encapsulated TClient to do the actual work.
this behaviour should be optional configurable at the Connection level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to fall into infinite cycle until connection is re-established and command retried and executed successfully. For write operations retrying isn't performed and exceptions propagated, but connection is refreshed to be successful during the subsequent calls.