Add registration and dynamic validation for accelerator. - #377
Open
TeresiaOlsson wants to merge 2 commits into
Open
Add registration and dynamic validation for accelerator.#377TeresiaOlsson wants to merge 2 commits into
TeresiaOlsson wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The accelerator was also missing registering the schema and the dynamic validation.
I had to turn of the validation in some tests because when including it the tests failed at the validation step since registering the schemas from tango-pyaml has not been implemented yet.
I'm not sure if these tests should require tango-pyaml. It seems a bit fragile to me to have tests inside pyaml which are dependent on the other packages. Maybe the tests that require it should be moved to the integration tests?