Add ruff format check to ci.yml#2947
Conversation
janiversen
left a comment
There was a problem hiding this comment.
Something seems a bit off, "ruff format --check" runs ok on dev, but this PR have an error
|
Looks like |
|
When I run diff --git a/test/client/test_client.py b/test/client/test_client.py
index 7e9f5a4b..ee052c3c 100755
--- a/test/client/test_client.py
+++ b/test/client/test_client.py
@@ -380,7 +380,8 @@ class TestMixin:
with pytest.raises(TypeError):
ModbusClientMixin.convert_to_registers(
- bool, ModbusClientMixin.DATATYPE.BITS # type: ignore[arg-type]
+ bool,
+ ModbusClientMixin.DATATYPE.BITS, # type: ignore[arg-type]
)
def test_client_mixin_convert_datatype_fail(self): |
|
Looks correct, feel free to submit it as a separate PR. I expect that Zuban will mark an error. |
|
Please do not mix code changes with CI changes. |
|
The problem was that ruff moved the ignore comment that zuban relied on. I formatted with ruff and fixed teh ignore comment in #2948. |
|
#2948 could be merged first. Then I can then merge those changes into this PR so that all the new ci checks pass. I'll tidy up this pr to only include changes to |
0065636 to
dbee8fa
Compare
janiversen
left a comment
There was a problem hiding this comment.
Good catch (check_ci).
LGTM, thanks
Added format checking with ruff using
ruff format --check.See: #2944 (comment)