Treat datetime formula predictors as continuous#1007
Open
drbenvincent wants to merge 1 commit into
Open
Conversation
drbenvincent
force-pushed
the
cursor/dbf2f2c8
branch
from
e37c7c7 to
cf04155
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1007 +/- ##
==========================================
+ Coverage 95.51% 95.54% +0.02%
==========================================
Files 98 100 +2
Lines 15868 15969 +101
Branches 931 934 +3
==========================================
+ Hits 15157 15258 +101
Misses 504 504
Partials 207 207 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Documentation build overview
12 files changed ·
|
Encode bare datetime factors as elapsed days while preserving explicit categorical factors and out-of-sample design compatibility. Co-authored-by: Cursor <[email protected]>
drbenvincent
force-pushed
the
cursor/dbf2f2c8
branch
from
cf04155 to
8c023a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
C(date)for explicit categorical date effects and retain datetime-awarestep()/ramp()behavior.Fixes #1002
Testing
prek run --all-filesmake test-patch-covMade with Cursor