fix: [#257] Resolve profile execute to cwd instead of package install dir #263
Merged
Merged
Conversation
Contributor
|
Thx 4 your effort @hendo-21 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #257.
profile.execute()against cwd instead ofPath(__file__).resolve().parents[1](the package install dir), so it can locate templates pulled viafenn pull.template.parent != ROOTguard to allow profiling of templates nested within cwd.test_profile_execute_generates_profile_and_reportto parametrize over flat and nested templates; retains original coverage for the non-nested case.profile.execute()raisesSystemExit(1)for a template dir missingmain.py.Verification