Conversation
Checking Gatan EELS
update branch
AustinHouston
marked this pull request as ready for review
August 12, 2026 00:06
| return labels | ||
|
|
||
|
|
||
| class SEGMENTATION(Device): |
Collaborator
There was a problem hiding this comment.
I think we should call this SamSEGMENTATION. As we will have simple unets to segment as well. I think a base SEGMENT class might be a good idea in long run.
Collaborator
There was a problem hiding this comment.
I wonder why is it under mcp folder? Shall we create a post-processing folder?
Collaborator
There was a problem hiding this comment.
I was thinking maybe rename the folder to "intelligence" or something like that? Since llm.py also lives under that folder aswell
Collaborator
There was a problem hiding this comment.
Again, I think this should be named - SAMsegmentation.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a standalone GPU segmentation workflow, splits the aberration corrector into concrete CEOS and digital-twin backends, and expands the acquisition and simulation examples around those services.
Review focus
1. Segmentation service
startup_scripts/run_segmentation.pyandconfigs/Segmentation.yaml; the launcher starts only the segmentation server against an existing Tango/DATA/Tiled stack.2. Corrector backend split
CORRECTORTango API and separates concrete implementations intoCEOSCorrectorandDigitalTwinCorrector.3. 4D-STEM acquisition and data handling
4. Polycrystalline-gold digital twin
Additional cleanup
electron_countingcamera setting from the Tango device, shared microscope contract, digital twins, tests, and notebooks.06_Digital_Twin_Tilt.ipynbintentionally;06_Segmentation.ipynbnow occupies that numbered example slot.run_servers.pyflow unchanged; segmentation uses its standalone runner.Validation
uv run --extra segment --extra diffraction ruff check ...uv run --extra segment --extra diffraction pytest tests/test_segment.py tests/test_run_segmentation.py tests/test_data_device.py tests/test_corrector.py tests/test_polycrystalline_gold_digital_twin.py tests/test_auto_script_microscope.py tests/test_run_servers.py tests/test_digital_twin_diffraction.py tests/test_digital_twin_tilt.py tests/test_CAMERA.py -q— 82 passedjq empty