Use milestone aliases for TURD creatures#400
Merged
Merged
Conversation
This allows the TURD creature to still trigger the original milestone, without creating a separate milestone.
Contributor
|
Thanks for taking the time to add this. The original preset is actually thanks to another git contributor, @chunkybanana |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the comments I think the niche "alias" feature of Milestones would be more appropriate here for the TURD creatures. This allows the TURD creature to still trigger the original milestone, without creating a separate milestone. e.g. creating either a
digosaurusor adigosaurus-turdwill trigger the same milestone.(As my modding time is limited these days, I'm looking into having all the innate presets in Milestones handled migrated to their own mod. I was pleasantly surprised to see that Pyanodons already did this! You guys are awesome, had to add my small contribution. The next Milestones update will remove the innate and outdated "Full PyMods" preset.)