Fix/code refactor - #223
Merged
Merged
Conversation
MinetteMeyo
reviewed
Apr 30, 2026
| @@ -30,13 +30,13 @@ | |||
| @ComponentScan(basePackages = "ca.concordia.encs.citydata.core") | |||
| public class MergeOperationTests extends AbstractTest { | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
Why was this test commented? It seems valid. Let's uncomment it and ensure it passes for the next release
MinetteMeyo
reviewed
Apr 30, 2026
| @@ -74,14 +74,14 @@ public void testNoBuildings() throws Exception { | |||
| } | |||
| } | |||
|
|
|||
Collaborator
There was a problem hiding this comment.
This commented-out test should be removed. It was added early in development to validate the logic under all scenarios, but now that the codebase is stable, it’s no longer needed.
MinetteMeyo
approved these changes
Apr 30, 2026
MinetteMeyo
left a comment
MinetteMeyo
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. I’ll go ahead and approve and merge the PR, and we can address my comments in our next pair programming session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressed Issue #222