Skip to content

Removing deprecated APIs #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
johannesconsulting wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Removing deprecated APIs #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 4 additions & 50 deletions Tests/Add-PASGroupMember.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {
}

$InputObj = [pscustomobject]@{
'GroupName' = 'SomeGroup'
'UserName' = 'SomeUser'

}

$InputObjV10 = [pscustomobject]@{
'memberId' = 'someName'
'memberType' = 'domain'
'domainName' = 'SomeDomain'
Expand All @@ -66,8 +60,8 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {
}
Context 'Mandatory Parameters' {

$Parameters = @{Parameter = 'GroupName' },
@{Parameter = 'UserName' }
$Parameters = @{Parameter = 'groupId' },
@{Parameter = 'memberId' }

It 'specifies parameter <Parameter> as mandatory' -TestCases $Parameters {

Expand Down Expand Up @@ -95,19 +89,7 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$URI -eq "$($Script:psPASSession.BaseURI)/WebServices/PIMServices.svc/Groups/SomeGroup/Users/"

} -Times 1 -Exactly -Scope It

}

It 'sends request to expected endpoint - V10' {

$InputObjV10 | Add-PASGroupMember

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$URI -eq "$($Script:psPASSession.BaseURI)/API/UserGroups/$($InputObjV10.groupId)/Members"
$URI -eq "$($Script:psPASSession.BaseURI)/API/UserGroups/$($InputObj.groupId)/Members"

} -Times 1 -Exactly -Scope It

Expand All @@ -121,14 +103,6 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

}

It 'uses expected method - V10' {

$InputObjV10 | Add-PASGroupMember

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter { $Method -match 'POST' } -Times 1 -Exactly -Scope It

}

It 'sends request with expected body' {

$InputObj | Add-PASGroupMember
Expand All @@ -145,26 +119,6 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

It 'has a request body with expected number of properties' {

($Script:RequestBody | Get-Member -MemberType NoteProperty).length | Should -Be 1

}

It 'sends request with expected body - v10' {

$InputObjV10 | Add-PASGroupMember

Assert-MockCalled Invoke-PASRestMethod -ParameterFilter {

$Script:RequestBody = $Body | ConvertFrom-Json

($Script:RequestBody) -ne $null

} -Times 1 -Exactly -Scope It

}

It 'has a request body with expected number of properties - V10' {

($Script:RequestBody | Get-Member -MemberType NoteProperty).length | Should -Be 3

}
Expand All @@ -174,7 +128,7 @@ Describe $($PSCommandPath -Replace '.Tests.ps1') {

$psPASSession.ExternalVersion = '1.0'

{ $InputObjV10 | Add-PASGroupMember } | Should -Throw
{ $InputObj | Add-PASGroupMember } | Should -Throw

$psPASSession.ExternalVersion = '0.0'

Expand Down
155 changes: 0 additions & 155 deletions Tests/Add-PASPendingAccount.Tests.ps1
View file
Open in desktop

This file was deleted.

Loading