Adds subgraph support#16
Conversation
Fixes #8
|
Other than the |
|
@SebastienGllmt thank you, I fixed that in my fork. |
|
please resolve conflicts |
|
and in case no tests, pls add tests. I'll consider the pull after resolve |
|
okey, I tried to pull in the rank and this but am baffled where as_slice() is supposed to come from? Pls review the merge. |
|
@przygienda I did some digging, it seems like Lines 417 to 419 in f11625c As for tests, this PR does have one test. If you want more and the original author @sanpii isn't available, I'd be happy to write some. |
|
ok, merged and pushed onto devel now, unittests pass but it would be good you review quickly and then we can publish |
|
and ideally, add some more tests |
|
Okay, reviewing is done. This code looks good. I'll write some more unit tests later today. |
|
perfect. poke me when ready for a pull and I'll pull up and publish when I
get to it
…On Thu, Jul 2, 2026 at 10:36 AM stefnotch ***@***.***> wrote:
*stefnotch* left a comment (przygienda/dot-rust#16)
<#16 (comment)>
Okay, reviewing is done. This code looks good.
I'll write some more unit tests later today.
—
Reply to this email directly, view it on GitHub
<#16?email_source=notifications&email_token=AANDIC436SBNEFM4YOAXTKD5CYNKVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGM4DANJUHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-4863805485>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANDIC6EHDEK22BKTPYLAVL5CYNKVAVCNFSNUABDKJSXA33TNF2G64TZHMZTGNZVGQ4DCOJ3JFZXG5LFHM4DMMRXGY4DAOJQUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/AANDIC6LVVLV55UJV6BA4OL5CYNKVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGM4DANJUHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJKTGN5XXIZLSL5UW64Y>
and Android
<https://github.com/notifications/mobile/android/AANDIC4T2Z4D3XUCF2O4XYD5CYNKVA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTIOBWGM4DANJUHA22M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLTGN5XXIZLSL5QW4ZDSN5UWI>.
Download it today!
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Fixes #8