Skip to content

Adds subgraph support#16

Open
sanpii wants to merge 1 commit into
przygienda:developfrom
sanpii:subgraph
Open

Adds subgraph support#16
sanpii wants to merge 1 commit into
przygienda:developfrom
sanpii:subgraph

Conversation

@sanpii

@sanpii sanpii commented Apr 20, 2021

Copy link
Copy Markdown
Contributor

Fixes #8

  • Subgraph support
  • Documentation
    • API
    • example
  • Tests

@sanpii sanpii marked this pull request as ready for review August 6, 2021 09:39
@SebastienGllmt

Copy link
Copy Markdown

Other than the .dot output format missing the proper tabbing, this worked perfectly for me! Thanks a lot

@sanpii

sanpii commented May 10, 2022

Copy link
Copy Markdown
Contributor Author

@SebastienGllmt thank you, I fixed that in my fork.

@przygienda

Copy link
Copy Markdown
Owner

please resolve conflicts

spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this pull request Aug 31, 2024
spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this pull request Aug 31, 2024
spikespaz pushed a commit to spikespaz/dotwalk-rs that referenced this pull request Aug 31, 2024
@przygienda

Copy link
Copy Markdown
Owner

and in case no tests, pls add tests. I'll consider the pull after resolve

@przygienda

Copy link
Copy Markdown
Owner

okey, I tried to pull in the rank and this but am baffled where as_slice() is supposed to come from? Pls review the merge.

@stefnotch

Copy link
Copy Markdown
Contributor

@przygienda I did some digging, it seems like Id::as_slice was the old name for Id::as_str

dot-rust/src/lib.rs

Lines 417 to 419 in f11625c

pub fn as_slice(&'a self) -> &'a str {
&*self.name
}

As for tests, this PR does have one test. If you want more and the original author @sanpii isn't available, I'd be happy to write some.

@przygienda

Copy link
Copy Markdown
Owner

ok, merged and pushed onto devel now, unittests pass but it would be good you review quickly and then we can publish

@przygienda

Copy link
Copy Markdown
Owner

and ideally, add some more tests

@stefnotch stefnotch mentioned this pull request Jul 2, 2026
@stefnotch

Copy link
Copy Markdown
Contributor

Okay, reviewing is done. This code looks good.

I'll write some more unit tests later today.

@przygienda

przygienda commented Jul 2, 2026 via email

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subgraph support

4 participants