Adding support for endianness in TypedBuffer codecs#233
Merged
Conversation
avalerio-tkd
commented
Mar 19, 2026
avalerio-tkd
commented
Collaborator
- Adding endianness protection to the codecs.
- Moving the Int96 codec to a separate codec class.
- Small update to TypedBuffer printout.
- Unitests updated.
- Moving the Int96 codec to a separate codec class. - Small update to TypedBuffer printout. - Unitests updated.
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this! Overall LGTM. Did leave a few comments.
- Updated comments on Int96 struct.
Collaborator
Author
|
Thanks @argmarco-tkd for the careful review as always. Left a few clarification questions for you. Once those are clear, I'll make the changes. |
avalerio-tkd
commented
Mar 19, 2026
avalerio-tkd
left a comment
avalerio-tkd
left a comment
Collaborator
Author
There was a problem hiding this comment.
Updated. Could you PTAL?
…fers. - Updated comments on code duplication.
argmarco-tkd
approved these changes
Mar 19, 2026
argmarco-tkd
left a comment
argmarco-tkd
left a comment
Collaborator
There was a problem hiding this comment.
thanks for the quick turnaround. LGTM - ship it!
Collaborator
Author
|
Thanks. Updated the comment on UINT32 to clarify why these are kept separate. Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.