frontend: replace alert() with Toast (#1718)#1722
Merged
Merged
Conversation
Swap all 7 native alert() calls in App.tsx for the existing addToast() API (type 'error', 5000ms), matching the surrounding toast usage. Covers the 'Server not connected' guard (4x) and the missing-URL validations in the bug/fix/change handlers. window.confirm() stale-session dialogs are left as-is since they require a yes/no return a toast cannot provide. Closes #1718 Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace all 7 native
alert()calls inpdd/frontend/App.tsxwith the existingaddToast()API. Sub-PR of EPIC #1720 — targetsepic/frontend-ui-polish, not main.Why
alert()is an unbranded, page-blocking OS dialog. The app already has a Toast system (useToast/addToast, destructured atApp.tsx:82and used ~20 times nearby). These 7 sites were the last hold-outs.Mapping
All 7 are blocking error/validation conditions, so each becomes
addToast(msg, 'error', 5000)— consistent with the existingaddToast('Error: …', 'error', 5000)pattern:Out of scope (intentionally untouched)
The 4
window.confirm()stale-session dialogs stay — they need a yes/no return value a toast can't provide.Verification
alert()calls remain inApp.tsxwindow.confirm()dialogs preservednpm test(vitest) — 54 passed / 12 filesCloses #1718
🤖 Generated with Claude Code