Fix: apply DialContextFunc to OAuth2 token-fetch transport#911
Open
yuri-tceretian wants to merge 1 commit into
Open
Fix: apply DialContextFunc to OAuth2 token-fetch transport#911yuri-tceretian wants to merge 1 commit into
yuri-tceretian wants to merge 1 commit into
Conversation
newOauth2TokenSource builds its own http.Transport to fetch tokens but doesn't set DialContext on it. Any DialContextFunc passed via WithDialContextFunc is applied to the main request transport but silently skipped for the token endpoint. Set DialContext on the token transport the same way it is set on the main one. When dialContextFunc is nil the behaviour is unchanged since http.Transport falls back to its default dialer. Added TestOAuth2DialContextFunc to verify that WithDialContextFunc blocks the token endpoint fetch, not only the final request. Signed-off-by: Yuri Tseretyan <[email protected]>
yuri-tceretian
force-pushed
the
fix/oauth2-token-transport-dialcontextfunc
branch
from
3fb131c to
7a5a530
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
function
newOauth2TokenSourcebuilds its ownhttp.Transportto fetch tokens but doesn't set DialContext on it. Any DialContextFunc passed via WithDialContextFunc is applied to the main request transport but silently skipped for the token endpoint.Solution
The fix is a one-liner - set DialContext on the token transport the same way it's set on the main one. When dialContextFunc is nil the behaviour is unchanged since http.Transport falls back to its default dialer.