chore: rename module to @prometheus/client_js#751
Conversation
|
I know that @krajorama mentioned Reality check: Go is of course an outlier since it imports directly from domain's namespace. And in Go packages with
|
|
I don't have a strong opinion, I feel that @prometheus-io/client_js would be nice to reflect the name of the repo it comes from, but I'm ok with @prometheus-io/client as well. (Note : currently Prometheus publishes packages under prometheus-io). @jdmarshall any preference? UPDATE: as far as I see I can freely add @prometheus organization, so we can do @prometheus prefix as well. |
|
Personally, I think |
This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move.
| 'prom-client@latest': 'prom-client@latest', | ||
| 'prom-client@trunk': '[email protected]:siimon/prom-client', | ||
| 'prom-client@current': { location: process.cwd() }, | ||
| '@prometheus-io/client@latest': '@prometheus-io/client@latest', |
There was a problem hiding this comment.
These are going to conflict with another PR that simplifies the names for the benchmarks. I'm landing that momentarily.
This commit updates the project name from prom-client to @prometheus/client_js to reflect the recent move.
This is my first time contributing to this project under any package name, so please let me know if anything here is incorrect.