perf: use the faster api to collect rss#742
Open
chidam333 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates default RSS collection on non-Linux platforms to use Node’s faster RSS-only API, reducing overhead during metrics collection.
Changes:
- Switch non-Linux
process_resident_memory_bytescollection fromprocess.memoryUsage()toprocess.memoryUsage.rss(). - Add a new
safeRss()helper to safely read RSS with a try/catch wrapper.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/metrics/osMemoryHeap.js | Uses safeRss() to collect RSS for the non-Linux variant of process_resident_memory_bytes. |
| lib/metrics/helpers/safeRss.js | Introduces a helper that calls process.memoryUsage.rss() and swallows platform/runtime errors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+5
to
+7
| try { | ||
| return process.memoryUsage.rss(); | ||
| } catch { |
Comment on lines
+20
to
25
| // process.memoryUsage.rss() is faster than process.memoryUsage() as it | ||
| // only reads RSS from the OS without collecting all heap statistics | ||
| const rss = safeRss(); | ||
| if (rss !== undefined) { | ||
| this.set(labels, rss); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://nodejs.org/api/process.html#processmemoryusagerss
i think we can use the faster api to collect rss