-
Notifications
You must be signed in to change notification settings - Fork 400
feat: allow specifying timeout for cluster metrics aggregation #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+12
−3
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -36,10 +36,12 @@ class AggregatorRegistry extends Registry { | |
| /** | ||
| * Gets aggregated metrics for all workers. The optional callback and | ||
| * returned Promise resolve with the same value; either may be used. | ||
| * @param {ClusterMetricsOptions|undefined} options Additional options for cluster metrics aggregation. | ||
|
vitush93 marked this conversation as resolved.
|
||
| * @param {number} [options.timeoutMs=5000] Timeout to wait for all workers to respond before error. | ||
| * @return {Promise<string>} Promise that resolves with the aggregated | ||
| * metrics. | ||
| */ | ||
| clusterMetrics() { | ||
| clusterMetrics(options = { timeoutMs: 5000 }) { | ||
| const requestId = requestCtr++; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not use the value passed into the constructor? |
||
|
|
||
| return new Promise((resolve, reject) => { | ||
|
|
@@ -58,7 +60,7 @@ class AggregatorRegistry extends Registry { | |
| errorTimeout: setTimeout(() => { | ||
| const err = new Error('Operation timed out.'); | ||
| request.done(err); | ||
| }, 5000), | ||
| }, options.timeoutMs || 5000), | ||
| }; | ||
| requests.set(requestId, request); | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.