Skip to content

WIP: Update vendored gopls to version 0.4.2#181

Draft
slrtbtfs wants to merge 14 commits into
masterfrom
update_gopls4.2
Draft

WIP: Update vendored gopls to version 0.4.2#181
slrtbtfs wants to merge 14 commits into
masterfrom
update_gopls4.2

Conversation

@slrtbtfs

@slrtbtfs slrtbtfs commented Jul 1, 2020

Copy link
Copy Markdown
Member

No description provided.

slrtbtfs added 14 commits July 1, 2020 16:15
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
The code was unused and broken due to previous API changes anyway.

If someone needs websocket support, it's a good idea to reimplement it from scratch.

Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
Signed-off-by: Tobias Guggenmos <[email protected]>
slrtbtfs added a commit that referenced this pull request Jul 7, 2020
The websocket module was never finished and due to API changes in various places, doesn't work in it's current form. Also it's incompatible with #181.

If someone wants to solve #55, it's better to start over.

Signed-off-by: Tobias Guggenmos <[email protected]>
@slrtbtfs slrtbtfs mentioned this pull request Jul 7, 2020
slrtbtfs added a commit that referenced this pull request Jul 17, 2020
Fixes #189.

This fixes some unchecked pointer accesses in the cache package.

Independently of how errors are handled, these checks should be in place.

Proper error handling as discussed in #189 and #181 can happen separately.

Signed-off-by: Tobias Guggenmos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant