fix: use cjs for exports#44
Open
achingbrain wants to merge 1 commit into
Open
Conversation
- Only export cjs code and let bundlers figure the rest out - Removes old bower/grunt toolchain - Adds standard for linting - Fixes all linting errors - Updates all deps - Removes peer deps since they get installed by default with npm7 - Replaces travis CI with github actions - Removes require-uncached as it doesn't bundle due to needing node internals and the tests pass without it?
Author
|
I've PRd this against my own fork so you can see the GH actions running - achingbrain#1 They won't run here until this PR is merged. |
Contributor
|
Very awesome @achingbrain! I'm down to make these changes; just 2 things. Would you mind splitting this into two PRs? One for toolchain changes and one with the CJS changes (are the tooling changes compatible with the universal module format)? Finally, I actually do not have maintainer access to this repo anymore so I'm moving this project to my personal repo at joshperry/dirty-chai. Would you mind opening a PR there instead? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is rather a big changeset so I'll understand if you don't want to merge this, but I've found problems using dirty-chai with modern bundlers like esbuild due to the way this module tries to support script tags, cjs and amd all from one file.
I think just supporting cjs is fine given most people are using webpack/rollup/esbuild/parcel/browserify/etc and they can all handle cjs.
Refs: evanw/esbuild#1202