Fix/pre v3 go live#40
Merged
Merged
Conversation
- Use raw.githubusercontent.com URL for the logo so it resolves on NuGet.org (the /blob/ URL served HTML, not the image) and point it at master instead of the stale dev/v2 branch - Make the migration-guide link absolute so it works on the package page - Enable package validation and TreatWarningsAsErrors; add Company and tidy the Copyright string Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
Make the passphrase separator a nullable char where null means no separator, so words are concatenated directly (e.g. mapleriverquartzbloom42). - PassphraseGenerator/PassphraseOptions/presets take char? separator - Generation appends the separator only when present (between words and before the trailing number) - DI: an explicitly empty Passphrase:Separator binds to null, since the config binder otherwise skips empty values and keeps the default - Entropy is unaffected (the separator never contributed to it) - Tests for no-separator output, capitalize, entropy parity and config binding; Readme and CHANGELOG updated Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
- README: fix duplicate variable in the presets example, absolutize all repo-relative links so they resolve on NuGet.org, give the async snippet an async context, and document CharacterClass values, DefaultBatchCount and an appSettings.json example - docs: note the optional/no separator and WordCountForEntropy in api-surface; add a passphrase appSettings example in configuration-and-di - Add <exception> tags to public throwing members that lacked them - Rename root Readme.md to README.md to match PackageReadmeFile and the package path (was only working via case-insensitive Windows) Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.