Bump libnostr-z to v0.3.6 (websocket handshake over-read fix)#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the libnostr-z dependency to v0.3.6 and noz to v0.2.1.
v0.3.6 fixes a WebSocket client handshake over-read (privkeyio/libnostr-z#134): the client discarded bytes read past the HTTP 101 response, so a relay's first frame (e.g. a NIP-42 AUTH challenge) was silently dropped when it arrived in the same TCP segment as the upgrade response. Under load this made
noz event --authintermittently fail (the challenge was lost, the next read timed out, the publish reported "rejected").With v0.3.6: 0 failures across 120 authed publishes under CPU contention and 50 full auth integration runs (previously ~10-17%).
zig buildpasses.