Fix payload generation to use actual form data#144
Merged
Conversation
- Use contentData.repo and contentData.path from form instead of hardcoded defaults - Add logging to show repo, path, and type values being received - This fixes the validation error where wrong path was being used - Now payload will use actual form values: repo='prepguides/go-interviews', path='patterns/README.md' - Resolves GitHub Actions validation failure with 404 errors
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
/approve |
Contributor
|
🚀 Admin-Approved and Auto-Merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Problem
The GitHub Actions validation was failing because the bot API was generating payload files with hardcoded default values instead of using the actual form data:
repo: "prepguides/go-interviews",path: "patterns/README.md"repo: "prepguides/prepguides.dev",path: "content/system-design/system-design-concurrency-model.md"This caused the validation to fail with a 404 error because it was looking for a file that doesn't exist in the wrong repository.
✅ Solution
Updated the
generatePayloadContentfunction inapi/github/create-content-pr.jsto use the actual form data:🧪 Testing
repo: "prepguides/go-interviews"path: "patterns/README.md"type: "Guide (GitHub Markdown)"📝 Expected Result
The GitHub Actions validation should now pass because it will be looking for the correct file in the correct repository:
prepguides/go-interviewsprepguides/go-interviews/patterns/README.md🔍 Additional Changes