Clear ML-DSA outputs on signing failure#1242
Conversation
mkannwischer
left a comment
There was a problem hiding this comment.
Thanks @tob-joe! Generally, I do support this change of clearing buffers on failures.
I'm not very happy about the added complexity to the test_alloc.c and test_rng_fail.c.
Can't we just modify the existing tests to init with with fixed values, and check it's zero in the end?
Please also rebase on top of main.
ca47b64 to
fe4f46f
Compare
CBMC Results (ML-DSA-44)Full Results (203 proofs)
|
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (203 proofs)
|
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (203 proofs)
|
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (203 proofs)
|
CBMC Results (ML-DSA-65)Full Results (203 proofs)
|
CBMC Results (ML-DSA-87)Full Results (203 proofs)
|
b1e02b1 to
9dba086
Compare
Zero caller-visible keypair and detached-signature outputs on error paths, including allocation, RNG, and keygen PCT failures. Update the existing allocation and RNG-failure tests to initialize caller outputs with fixed sentinels and assert that each exercised failure path clears them. Keep PCT-breakage coverage in the RNG-failure test because keygen PCT failure is not an RNG-failure injection point. Verification: - make clean run_alloc run_rng_fail - env MLD_BREAK_PCT=1 make clean run_rng_fail CFLAGS='-Itest -DMLD_CONFIG_FILE=\"../test/configs/break_pct_config.h\"' - lint - git diff --check Co-authored-by: Codex <[email protected]> Signed-off-by: Joe Doyle <[email protected]>
Reduced-api verify-only builds disable both keypair and sign APIs. In that configuration the allocation and RNG failure tests still compiled all_zero even though only verify tests remained, tripping -Werror=unused-function in CI. Compile all_zero only when the keypair or sign test cases are enabled. Verify tests keep their no-op output checks because the verify APIs expose no caller-owned output buffer to clear. Verification: - Focused reduced-api alloc/rng-fail with ASan/UBSan flags passed. - Focused reduced-api-reduce-ram alloc/rng-fail with ASan/UBSan flags passed. - git diff --check passed. Co-authored-by: Codex <[email protected]> Signed-off-by: Joe Doyle <[email protected]>
9dba086 to
f143afc
Compare
|
Is there a performance penalty to this? Added benchmark label to see if it will pick up anything. Did you do any locally testing on performance? |
There was a problem hiding this comment.
Mac Mini (M1, 2020) benchmarks (opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
46532 cycles |
46524 cycles |
1.00 |
ML-DSA-44 sign |
131208 cycles |
131158 cycles |
1.00 |
ML-DSA-44 verify |
47347 cycles |
47327 cycles |
1.00 |
ML-DSA-65 keypair |
81682 cycles |
81704 cycles |
1.00 |
ML-DSA-65 sign |
215356 cycles |
215402 cycles |
1.00 |
ML-DSA-65 verify |
79305 cycles |
79316 cycles |
1.00 |
ML-DSA-87 keypair |
132412 cycles |
132438 cycles |
1.00 |
ML-DSA-87 sign |
277590 cycles |
277438 cycles |
1.00 |
ML-DSA-87 verify |
134055 cycles |
134054 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Mac Mini (M1, 2020) benchmarks (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
112847 cycles |
112790 cycles |
1.00 |
ML-DSA-44 sign |
401240 cycles |
401108 cycles |
1.00 |
ML-DSA-44 verify |
119505 cycles |
119469 cycles |
1.00 |
ML-DSA-65 keypair |
192943 cycles |
192920 cycles |
1.00 |
ML-DSA-65 sign |
650114 cycles |
649987 cycles |
1.00 |
ML-DSA-65 verify |
192893 cycles |
192911 cycles |
1.00 |
ML-DSA-87 keypair |
318850 cycles |
318805 cycles |
1.00 |
ML-DSA-87 sign |
828897 cycles |
828874 cycles |
1.00 |
ML-DSA-87 verify |
326860 cycles |
326791 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks (opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
112010 cycles |
112145 cycles |
1.00 |
ML-DSA-44 sign |
353609 cycles |
353664 cycles |
1.00 |
ML-DSA-44 verify |
117237 cycles |
117210 cycles |
1.00 |
ML-DSA-65 keypair |
194380 cycles |
194423 cycles |
1.00 |
ML-DSA-65 sign |
583869 cycles |
583751 cycles |
1.00 |
ML-DSA-65 verify |
193157 cycles |
193229 cycles |
1.00 |
ML-DSA-87 keypair |
320272 cycles |
320030 cycles |
1.00 |
ML-DSA-87 sign |
747437 cycles |
747793 cycles |
1.00 |
ML-DSA-87 verify |
318299 cycles |
317948 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
43351 cycles |
43317 cycles |
1.00 |
ML-DSA-44 sign |
130142 cycles |
130203 cycles |
1.00 |
ML-DSA-44 verify |
45064 cycles |
45356 cycles |
0.99 |
ML-DSA-65 keypair |
75691 cycles |
75546 cycles |
1.00 |
ML-DSA-65 sign |
213826 cycles |
213879 cycles |
1.00 |
ML-DSA-65 verify |
74423 cycles |
74538 cycles |
1.00 |
ML-DSA-87 keypair |
123380 cycles |
123153 cycles |
1.00 |
ML-DSA-87 sign |
271119 cycles |
270344 cycles |
1.00 |
ML-DSA-87 verify |
120789 cycles |
120702 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
50223 cycles |
46629 cycles |
1.08 |
ML-DSA-44 sign |
141714 cycles |
138231 cycles |
1.03 |
ML-DSA-44 verify |
49623 cycles |
49282 cycles |
1.01 |
ML-DSA-65 keypair |
82391 cycles |
81985 cycles |
1.00 |
ML-DSA-65 sign |
228162 cycles |
225547 cycles |
1.01 |
ML-DSA-65 verify |
81539 cycles |
81950 cycles |
0.99 |
ML-DSA-87 keypair |
128617 cycles |
128720 cycles |
1.00 |
ML-DSA-87 sign |
279328 cycles |
277529 cycles |
1.01 |
ML-DSA-87 verify |
127888 cycles |
127816 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'AMD EPYC 4th gen (c7a)'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.03.
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
50223 cycles |
46629 cycles |
1.08 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Intel Xeon 4th gen (c7i) (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
91506 cycles |
91412 cycles |
1.00 |
ML-DSA-44 sign |
352258 cycles |
352090 cycles |
1.00 |
ML-DSA-44 verify |
99906 cycles |
99969 cycles |
1.00 |
ML-DSA-65 keypair |
153893 cycles |
153968 cycles |
1.00 |
ML-DSA-65 sign |
571767 cycles |
572041 cycles |
1.00 |
ML-DSA-65 verify |
159847 cycles |
159945 cycles |
1.00 |
ML-DSA-87 keypair |
255311 cycles |
255217 cycles |
1.00 |
ML-DSA-87 sign |
725870 cycles |
726289 cycles |
1.00 |
ML-DSA-87 verify |
263919 cycles |
263820 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
51972 cycles |
51836 cycles |
1.00 |
ML-DSA-44 sign |
155391 cycles |
154512 cycles |
1.01 |
ML-DSA-44 verify |
54305 cycles |
54139 cycles |
1.00 |
ML-DSA-65 keypair |
89774 cycles |
89155 cycles |
1.01 |
ML-DSA-65 sign |
251991 cycles |
252934 cycles |
1.00 |
ML-DSA-65 verify |
89325 cycles |
89565 cycles |
1.00 |
ML-DSA-87 keypair |
142048 cycles |
142627 cycles |
1.00 |
ML-DSA-87 sign |
310417 cycles |
312120 cycles |
0.99 |
ML-DSA-87 verify |
138689 cycles |
139226 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A55 (Snapdragon 888) benchmarks (opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
270783 cycles |
270738 cycles |
1.00 |
ML-DSA-44 sign |
824911 cycles |
819744 cycles |
1.01 |
ML-DSA-44 verify |
275488 cycles |
275272 cycles |
1.00 |
ML-DSA-65 keypair |
466459 cycles |
466759 cycles |
1.00 |
ML-DSA-65 sign |
1328999 cycles |
1341171 cycles |
0.99 |
ML-DSA-65 verify |
452100 cycles |
451207 cycles |
1.00 |
ML-DSA-87 keypair |
796882 cycles |
799586 cycles |
1.00 |
ML-DSA-87 sign |
1837273 cycles |
1849427 cycles |
0.99 |
ML-DSA-87 verify |
779135 cycles |
778504 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
61587 cycles |
61451 cycles |
1.00 |
ML-DSA-44 sign |
188514 cycles |
188135 cycles |
1.00 |
ML-DSA-44 verify |
66279 cycles |
66473 cycles |
1.00 |
ML-DSA-65 keypair |
110673 cycles |
108648 cycles |
1.02 |
ML-DSA-65 sign |
314706 cycles |
312439 cycles |
1.01 |
ML-DSA-65 verify |
110384 cycles |
109517 cycles |
1.01 |
ML-DSA-87 keypair |
172474 cycles |
171731 cycles |
1.00 |
ML-DSA-87 sign |
379315 cycles |
377596 cycles |
1.00 |
ML-DSA-87 verify |
170728 cycles |
170346 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
AMD EPYC 4th gen (c7a) (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
118433 cycles |
117918 cycles |
1.00 |
ML-DSA-44 sign |
457721 cycles |
457220 cycles |
1.00 |
ML-DSA-44 verify |
130523 cycles |
129921 cycles |
1.00 |
ML-DSA-65 keypair |
200713 cycles |
200829 cycles |
1.00 |
ML-DSA-65 sign |
745099 cycles |
742025 cycles |
1.00 |
ML-DSA-65 verify |
209006 cycles |
208797 cycles |
1.00 |
ML-DSA-87 keypair |
329548 cycles |
330135 cycles |
1.00 |
ML-DSA-87 sign |
938876 cycles |
934677 cycles |
1.00 |
ML-DSA-87 verify |
343182 cycles |
344222 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton5
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
51547 cycles |
51433 cycles |
1.00 |
ML-DSA-44 sign |
162083 cycles |
162012 cycles |
1.00 |
ML-DSA-44 verify |
54640 cycles |
54757 cycles |
1.00 |
ML-DSA-65 keypair |
90156 cycles |
90180 cycles |
1.00 |
ML-DSA-65 sign |
267405 cycles |
268065 cycles |
1.00 |
ML-DSA-65 verify |
89793 cycles |
89928 cycles |
1.00 |
ML-DSA-87 keypair |
145920 cycles |
145887 cycles |
1.00 |
ML-DSA-87 sign |
336091 cycles |
335527 cycles |
1.00 |
ML-DSA-87 verify |
145487 cycles |
144958 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A76 (Raspberry Pi 5) benchmarks (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
211737 cycles |
211724 cycles |
1.00 |
ML-DSA-44 sign |
760337 cycles |
759874 cycles |
1.00 |
ML-DSA-44 verify |
229541 cycles |
229517 cycles |
1.00 |
ML-DSA-65 keypair |
378019 cycles |
377914 cycles |
1.00 |
ML-DSA-65 sign |
1246942 cycles |
1246728 cycles |
1.00 |
ML-DSA-65 verify |
372126 cycles |
371980 cycles |
1.00 |
ML-DSA-87 keypair |
601720 cycles |
600873 cycles |
1.00 |
ML-DSA-87 sign |
1582444 cycles |
1581216 cycles |
1.00 |
ML-DSA-87 verify |
617666 cycles |
616851 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton4
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
67330 cycles |
67221 cycles |
1.00 |
ML-DSA-44 sign |
198448 cycles |
198329 cycles |
1.00 |
ML-DSA-44 verify |
70184 cycles |
70202 cycles |
1.00 |
ML-DSA-65 keypair |
119423 cycles |
119328 cycles |
1.00 |
ML-DSA-65 sign |
325784 cycles |
326385 cycles |
1.00 |
ML-DSA-65 verify |
116824 cycles |
116914 cycles |
1.00 |
ML-DSA-87 keypair |
196667 cycles |
196585 cycles |
1.00 |
ML-DSA-87 sign |
421954 cycles |
421660 cycles |
1.00 |
ML-DSA-87 verify |
193355 cycles |
193024 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
AMD EPYC 3rd gen (c6a) (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
133241 cycles |
133101 cycles |
1.00 |
ML-DSA-44 sign |
519470 cycles |
519290 cycles |
1.00 |
ML-DSA-44 verify |
146604 cycles |
146343 cycles |
1.00 |
ML-DSA-65 keypair |
223500 cycles |
224195 cycles |
1.00 |
ML-DSA-65 sign |
842422 cycles |
843033 cycles |
1.00 |
ML-DSA-65 verify |
233986 cycles |
234168 cycles |
1.00 |
ML-DSA-87 keypair |
367254 cycles |
366577 cycles |
1.00 |
ML-DSA-87 sign |
1059895 cycles |
1058137 cycles |
1.00 |
ML-DSA-87 verify |
381753 cycles |
380302 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Intel Xeon 3rd gen (c6i) (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
153961 cycles |
153814 cycles |
1.00 |
ML-DSA-44 sign |
588677 cycles |
587991 cycles |
1.00 |
ML-DSA-44 verify |
169072 cycles |
168996 cycles |
1.00 |
ML-DSA-65 keypair |
262035 cycles |
261866 cycles |
1.00 |
ML-DSA-65 sign |
961173 cycles |
961798 cycles |
1.00 |
ML-DSA-65 verify |
271468 cycles |
271335 cycles |
1.00 |
ML-DSA-87 keypair |
432656 cycles |
432528 cycles |
1.00 |
ML-DSA-87 sign |
1212618 cycles |
1210167 cycles |
1.00 |
ML-DSA-87 verify |
447763 cycles |
446874 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton5 (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
99970 cycles |
100029 cycles |
1.00 |
ML-DSA-44 sign |
369204 cycles |
369119 cycles |
1.00 |
ML-DSA-44 verify |
110058 cycles |
110140 cycles |
1.00 |
ML-DSA-65 keypair |
174648 cycles |
174558 cycles |
1.00 |
ML-DSA-65 sign |
597390 cycles |
599151 cycles |
1.00 |
ML-DSA-65 verify |
178161 cycles |
178218 cycles |
1.00 |
ML-DSA-87 keypair |
286503 cycles |
285922 cycles |
1.00 |
ML-DSA-87 sign |
760899 cycles |
759458 cycles |
1.00 |
ML-DSA-87 verify |
296394 cycles |
296253 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton3
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
71536 cycles |
71486 cycles |
1.00 |
ML-DSA-44 sign |
209090 cycles |
208801 cycles |
1.00 |
ML-DSA-44 verify |
74800 cycles |
74918 cycles |
1.00 |
ML-DSA-65 keypair |
125977 cycles |
125917 cycles |
1.00 |
ML-DSA-65 sign |
345603 cycles |
345720 cycles |
1.00 |
ML-DSA-65 verify |
124059 cycles |
124421 cycles |
1.00 |
ML-DSA-87 keypair |
206581 cycles |
207047 cycles |
1.00 |
ML-DSA-87 sign |
439666 cycles |
444360 cycles |
0.99 |
ML-DSA-87 verify |
204484 cycles |
203973 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton4 (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
127653 cycles |
127732 cycles |
1.00 |
ML-DSA-44 sign |
441345 cycles |
440962 cycles |
1.00 |
ML-DSA-44 verify |
136358 cycles |
136482 cycles |
1.00 |
ML-DSA-65 keypair |
220771 cycles |
220440 cycles |
1.00 |
ML-DSA-65 sign |
714091 cycles |
714733 cycles |
1.00 |
ML-DSA-65 verify |
220665 cycles |
221428 cycles |
1.00 |
ML-DSA-87 keypair |
365200 cycles |
364306 cycles |
1.00 |
ML-DSA-87 sign |
915510 cycles |
915947 cycles |
1.00 |
ML-DSA-87 verify |
370856 cycles |
371317 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton2
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
112453 cycles |
112514 cycles |
1.00 |
ML-DSA-44 sign |
354064 cycles |
353832 cycles |
1.00 |
ML-DSA-44 verify |
117171 cycles |
117377 cycles |
1.00 |
ML-DSA-65 keypair |
194645 cycles |
194923 cycles |
1.00 |
ML-DSA-65 sign |
584387 cycles |
584471 cycles |
1.00 |
ML-DSA-65 verify |
193220 cycles |
193118 cycles |
1.00 |
ML-DSA-87 keypair |
320951 cycles |
321297 cycles |
1.00 |
ML-DSA-87 sign |
747176 cycles |
747721 cycles |
1.00 |
ML-DSA-87 verify |
318757 cycles |
318931 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton3 (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
138078 cycles |
138205 cycles |
1.00 |
ML-DSA-44 sign |
486144 cycles |
485965 cycles |
1.00 |
ML-DSA-44 verify |
149097 cycles |
149251 cycles |
1.00 |
ML-DSA-65 keypair |
241749 cycles |
241691 cycles |
1.00 |
ML-DSA-65 sign |
791601 cycles |
792289 cycles |
1.00 |
ML-DSA-65 verify |
241541 cycles |
243139 cycles |
0.99 |
ML-DSA-87 keypair |
396335 cycles |
395571 cycles |
1.00 |
ML-DSA-87 sign |
1013056 cycles |
1014534 cycles |
1.00 |
ML-DSA-87 verify |
403818 cycles |
404492 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
oqs-bot
left a comment
There was a problem hiding this comment.
Graviton2 (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
211631 cycles |
211948 cycles |
1.00 |
ML-DSA-44 sign |
759884 cycles |
759551 cycles |
1.00 |
ML-DSA-44 verify |
229180 cycles |
229366 cycles |
1.00 |
ML-DSA-65 keypair |
377263 cycles |
377678 cycles |
1.00 |
ML-DSA-65 sign |
1247013 cycles |
1248242 cycles |
1.00 |
ML-DSA-65 verify |
372689 cycles |
372697 cycles |
1.00 |
ML-DSA-87 keypair |
600463 cycles |
601178 cycles |
1.00 |
ML-DSA-87 sign |
1584817 cycles |
1584582 cycles |
1.00 |
ML-DSA-87 verify |
616450 cycles |
616670 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A55 (Snapdragon 888) benchmarks (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
465627 cycles |
465372 cycles |
1.00 |
ML-DSA-44 sign |
2136434 cycles |
2141728 cycles |
1.00 |
ML-DSA-44 verify |
556861 cycles |
559074 cycles |
1.00 |
ML-DSA-65 keypair |
784172 cycles |
784054 cycles |
1.00 |
ML-DSA-65 sign |
3488229 cycles |
3495166 cycles |
1.00 |
ML-DSA-65 verify |
867697 cycles |
867478 cycles |
1.00 |
ML-DSA-87 keypair |
1273606 cycles |
1283032 cycles |
0.99 |
ML-DSA-87 sign |
4324702 cycles |
4395370 cycles |
0.98 |
ML-DSA-87 verify |
1399074 cycles |
1403681 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
SpacemiT K1 8 (Banana Pi F3) benchmarks (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
759745 cycles |
759818 cycles |
1.00 |
ML-DSA-44 sign |
3137361 cycles |
3139267 cycles |
1.00 |
ML-DSA-44 verify |
858944 cycles |
858530 cycles |
1.00 |
ML-DSA-65 keypair |
1288488 cycles |
1288999 cycles |
1.00 |
ML-DSA-65 sign |
5082295 cycles |
5079065 cycles |
1.00 |
ML-DSA-65 verify |
1367718 cycles |
1368670 cycles |
1.00 |
ML-DSA-87 keypair |
2110805 cycles |
2110335 cycles |
1.00 |
ML-DSA-87 sign |
6342795 cycles |
6338237 cycles |
1.00 |
ML-DSA-87 verify |
2228729 cycles |
2227398 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks (opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
219096 cycles |
219242 cycles |
1.00 |
ML-DSA-44 sign |
596190 cycles |
597439 cycles |
1.00 |
ML-DSA-44 verify |
217500 cycles |
218271 cycles |
1.00 |
ML-DSA-65 keypair |
381463 cycles |
386466 cycles |
0.99 |
ML-DSA-65 sign |
987365 cycles |
992663 cycles |
0.99 |
ML-DSA-65 verify |
366170 cycles |
367437 cycles |
1.00 |
ML-DSA-87 keypair |
639625 cycles |
641685 cycles |
1.00 |
ML-DSA-87 sign |
1308102 cycles |
1323843 cycles |
0.99 |
ML-DSA-87 verify |
620689 cycles |
627671 cycles |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
Arm Cortex-A72 (Raspberry Pi 4) benchmarks (no-opt)
Details
| Benchmark suite | Current: f143afc | Previous: 1b816bb | Ratio |
|---|---|---|---|
ML-DSA-44 keypair |
301518 cycles |
301147 cycles |
1.00 |
ML-DSA-44 sign |
1140401 cycles |
1131790 cycles |
1.01 |
ML-DSA-44 verify |
331704 cycles |
330936 cycles |
1.00 |
ML-DSA-65 keypair |
550005 cycles |
541315 cycles |
1.02 |
ML-DSA-65 sign |
1890323 cycles |
1850240 cycles |
1.02 |
ML-DSA-65 verify |
532955 cycles |
521681 cycles |
1.02 |
ML-DSA-87 keypair |
842066 cycles |
850580 cycles |
0.99 |
ML-DSA-87 sign |
2372191 cycles |
2350706 cycles |
1.01 |
ML-DSA-87 verify |
871133 cycles |
874184 cycles |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Summary
signing fails
buffers
compiling the zeroization helper only when keypair or signing tests are
enabled
Notes
The reduced-api verify-only configuration disables both keypair and sign APIs.
Those verify tests intentionally keep no-op output checks because verification
does not expose a caller-owned output buffer that needs zeroing. Without the
API guard, the shared zeroization helper was compiled but unused in that mode,
which fails under
-Werror=unused-function.Testing
make run_rng_failmake run_allocmake run_unitmake run_funcgit diff --checkCo-authored-by: Codex [email protected]
Signed-off-by: Joe Doyle [email protected]
This work was completed by Trail of Bits as part of the Patch The Planet
project in collaboration with OpenAI. The issue was identified primarily by
the Codex coding agent, and manually reviewed before submission.