Harden benchmark workflow input handling#1233
Open
fegge wants to merge 3 commits into
Open
Conversation
Signed-off-by: Fredrik Dahlgren <[email protected]>
This was referenced Jun 26, 2026
Contributor
CBMC Results (ML-DSA-44, REDUCE-RAM)Full Results (203 proofs)
|
Contributor
CBMC Results (ML-DSA-65, REDUCE-RAM)Full Results (203 proofs)
|
Contributor
CBMC Results (ML-DSA-87, REDUCE-RAM)Full Results (203 proofs)
|
Contributor
CBMC Results (ML-DSA-65)Full Results (203 proofs)
|
Contributor
CBMC Results (ML-DSA-44)Full Results (203 proofs)
|
Contributor
CBMC Results (ML-DSA-87)Full Results (203 proofs)
|
mkannwischer
requested changes
Jun 29, 2026
mkannwischer
left a comment
Contributor
There was a problem hiding this comment.
Generally I support this hardening. Can you get it through CI please?
Contributor
There was a problem hiding this comment.
format isn't run in CI. Can you elaborate why it was changed in this PR?
Contributor
There was a problem hiding this comment.
Shouldn't lint be changed?
Contributor
Author
There was a problem hiding this comment.
That was a mistake. I've removed the hardening from format since it's not run in CI anyway, and have updated lint.
Comment on lines
+36
to
+37
| SAFE_MAKE_FLAG_RE = re.compile(r"^[A-Za-z0-9_.,:+=/@% -]*$") | ||
| SAFE_CROSS_PREFIX_RE = re.compile(r"^[A-Za-z0-9_./+-]*$") |
Contributor
There was a problem hiding this comment.
This seems to trip CI jobs passing a custom configuration file.
Contributor
Author
There was a problem hiding this comment.
Updated the SAFE_MAKE_FLAG_RE regexp to allow " and , so CI flags like -DMLD_CONFIG_FILE="..." pass.
Signed-off-by: Fredrik Dahlgren <[email protected]>
Signed-off-by: Fredrik Dahlgren <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
ruff format scripts/tests: passedruff check scripts/tests: passedpython3 -m py_compile scripts/tests: passedgit diff --check -- .github/actions/bench/action.yml .github/workflows/bench_ec2_any.yml .github/workflows/bench_ec2_reusable.yml scripts/format scripts/tests: passedbash -n scripts/format: passedshellcheck scripts/format: passedactionlint .github/workflows/bench_ec2_any.yml .github/workflows/bench_ec2_reusable.yml: passedzizmor .github/workflows/bench_ec2_any.yml .github/workflows/bench_ec2_reusable.yml .github/actions/bench/action.yml: passed with no findings--cflags,--ldflags, and--cross-prefixbenchmark CLI probes: rejected with exit code 2 and did not create marker files./scripts/formatbecausenixpkgs-fmtis not installed in this local environment./scripts/lintbecauseshfmtis not installed in this local environmentFixes #1213
This work was completed by Trail of Bits as part of the Patch The Planet project in collaboration with OpenAI. The issue was identified primarily by the Codex coding agent, and manually reviewed before submission.