You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@nmouha I'm continuing here with the exploration of adding CVC5 support alongside the existing solvers (bitwuzla, z3) that we use. Once we sort this, we can resume discussion on your proposal in #1114 and the corresponding change in mlkem-native.
If not given, then --solver=default is the default.
What is a "solver ID" anyway? Can I use one of the names of the wrapper
scripts that we have in proofs/cbmc/lib ?
For example, can I say --solver=z3_smt_only
to get proofs/cbmc/lib/z3_smt_only
Perhaps we should have a wrapper script called "z3" in the "lib" directory
that invokes z3 with no options at all - then we can insist that a "solver id"
really is the name of a wrapper script.
Then I could also say
--solver=z3,z3_smt_only,z3_something_else
to experiment with z3 options.
In the summary output, I need to know if the selected solver on each line of
output really is the default solver that would have been selected with --solver=default.
I suggest adding a "*" on the end of the solver ID to indicate "this one is the current default"
I also need to be able to easily see which solver is fastest, when the number of selected
solvers is >= 2. Combined with the suggestion above, I can easily tell if the current
defaut solver is the fastest of those chosen. Colour highlight the solver-id perhaps to indicate the winner?
In the summary output table when numnber of solvers >= 2, could you
add a blank line between the group of results for each function? That makes it easier
for my eye to see the results for each function in groups.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.