feat: Add an integration subcommand for manipulating integrations#776
Open
atheriel wants to merge 1 commit into
Open
feat: Add an integration subcommand for manipulating integrations#776atheriel wants to merge 1 commit into
integration subcommand for manipulating integrations#776atheriel wants to merge 1 commit into
Conversation
This commit adds a suite of CLI commands for managing "OAuth"
integrations:
$ rsconnect integration list
$ rsconnect integration show -g GUID
$ rsconnect integration add --template <key> [-N name] [-C key=value ...]
$ rsconnect integration edit -g GUID [-N name] [-C key=value ...]
$ rsconnect integration remove -g GUID
$ rsconnect integration templates list
$ rsconnect integration templates show --key <key>
The `edit` command merges `--config` fields with the existing
config (fetching it only when config changes are requested), so users
only need to specify fields they want to change.
ACLs can be passed via `--allow-user` and `--allow-group`.
Unit tests are included, as is autogenerated documentation.
Signed-off-by: Aaron Jacobs <[email protected]>
|
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
This commit adds a suite of CLI commands for managing "OAuth" integrations:
The
editcommand merges--configfields with the existing config (fetching it only when config changes are requested), so users only need to specify fields they want to change.ACLs can be passed via
--allow-userand--allow-group.Unit tests are included, as is autogenerated documentation.
Type of Change
Automated Tests
Unit tests are included. I also did a bunch of ad-hoc testing against a local Connect instance.
Directions for Reviewers
This is a pretty self-contained change, so the risk is low. To test it manually, try some of these out:
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.