-
Notifications
You must be signed in to change notification settings - Fork 28
Quickstart #767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amol-
wants to merge
27
commits into
main
Choose a base branch
from
quickstart
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Quickstart #767
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
b8cc145
Probe driven development plan
amol- 3127d44
rsconnect quickstart stub handler
amol- 41da31f
expose deploy pyproject command
amol- 6a10b18
Implement deploy pyproject
amol- d9eb6ea
setup the quickstart command infrastructure
amol- 0a7154c
basic templating infrastructure
amol- 3205a39
encapsulate templates
amol- b4ecf62
Quickstart command in place and working
amol- 304a737
quickstart templates for quarto, fastapi, jupyter, shiny
amol- a599925
documentation of quickstart command
amol- f54d719
quickstart command docs with testing infrastructure
amol- dca2b14
note about the known risk in tests, it's acceptable
amol- 79362e9
Preparing for graduation
amol- 6fe38cb
Merge branch 'main' into quickstart
amol- 749ef8b
use older click version
amol- 3b54bc0
backward compatibility older python
amol- e6db528
Isolate from host global conf
amol- 7ae1bf1
fixes for windows
amol- 3fb426d
Simplify python version logic
amol- 55d064c
Make pyproject a template file
amol- c7d522d
Move READMEs to their own template files
amol- 68f7329
Migrate from quarto --shiny to quarto-shiny
amol- 31f823d
Remove unecessay README
amol- e74a11b
Uniform toward AppModes
amol- 10001c9
uniform toward AppModes all commands
amol- 021771a
handle text decoding
amol- fecb0b0
Add --requirements-file option and requirements_file pyproject.toml o…
amol- File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| ::: mkdocs-click | ||
| :module: rsconnect.main | ||
| :command: quickstart |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,7 +139,7 @@ def handle_bad_response(self, response: HTTPResponse | T, is_httpresponse: bool | |
| if isinstance(response, HTTPResponse): | ||
| if response.exception: | ||
| raise RSConnectException( | ||
| "Exception trying to connect to %s - %s" % (self.url, response.exception), cause=response.exception | ||
| "Could not connect to %s - %s" % (self.url, response.exception), cause=response.exception | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Love this cleanup |
||
| ) | ||
| # Sometimes an ISP will respond to an unknown server name by returning a friendly | ||
| # search page so trap that since we know we're expecting JSON from Connect. This | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish this were
tool.connectrather thantool.rsconnectbut I imagine this was done since the CLI is stillrsconnect(and we aren't migrating away from that yet), yeah?