Skip to content

fix(windows): export KAIDEN_BINARY when installing Kaiden via -pdUrl#582

Open
serbangeorge-m wants to merge 1 commit into
podman-desktop:mainfrom
serbangeorge-m:fix-resolve-path
Open

fix(windows): export KAIDEN_BINARY when installing Kaiden via -pdUrl#582
serbangeorge-m wants to merge 1 commit into
podman-desktop:mainfrom
serbangeorge-m:fix-resolve-path

Conversation

@serbangeorge-m

Copy link
Copy Markdown
Contributor

Kaiden MAPT e2e runs install via -pdUrl but Playwright needs KAIDEN_BINARY, not PODMAN_DESKTOP_BINARY. This sets that env var after install and keeps Kaiden.exe instead of renaming it.

@serbangeorge-m
serbangeorge-m requested a review from odockal June 24, 2026 08:11
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Windows E2E runner gains Kaiden app detection via an $isKaidenApp flag. Across all three binary acquisition paths (setup URL install, download-only exe, direct path), Kaiden targets skip the rename-to-pd.exe step and assign $kaidenBinary directly. Load-Variables in common.ps1 then exports KAIDEN_BINARY as an environment variable. The README documents this behavior.

Changes

Kaiden Binary Support

Layer / File(s) Summary
Kaiden detection and binary path handling
pde2e-image/lib/windows/runner.ps1
Adds $kaidenBinary variable and $isKaidenApp flag computed from appName/repo. All three binary acquisition paths (setup URL install, download-only exe, direct $pdPath) branch on $isKaidenApp: Kaiden targets skip the rename-to-pd.exe step and assign $kaidenBinary directly from the resolved path.
KAIDEN_BINARY env export and documentation
pde2e-image/common/windows/common.ps1, pde2e-image/README.md
Load-Variables selects $kaidenBinary (falling back to $podmanDesktopBinary) when the app is Kaiden, sets env:KAIDEN_BINARY, and records it in $global:scriptEnvVars and $global:envVarDefs. README adds a note that the Kaiden binary is kept in %LOCALAPPDATA%\Programs\kaiden\ and that KAIDEN_BINARY is exported for the Playwright CDP harness.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main Windows Kaiden install change and the KAIDEN_BINARY export.
Description check ✅ Passed The description matches the PR by explaining KAIDEN_BINARY and preserving Kaiden.exe.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@pde2e-image/README.md`:
- Around line 294-295: The Kaiden setup docs currently imply `-appName Kaiden`
and `-repo kaiden` are interchangeable, but the setup path logic in the runner
depends on `$appName` for resolving `$appName.exe`. Update the README section
that describes setup-flow requirements to explicitly state that setup installs
must pass `-appName Kaiden` for `KAIDEN_BINARY` to point to the expected
executable, and only mention `-repo kaiden` as valid for non-setup/direct-path
scenarios if that is supported by the runner.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a1a7305-c6e4-4e96-bf61-82a0db2c6ffe

📥 Commits

Reviewing files that changed from the base of the PR and between d52ee9f and 9496a3e.

📒 Files selected for processing (3)
  • pde2e-image/README.md
  • pde2e-image/common/windows/common.ps1
  • pde2e-image/lib/windows/runner.ps1

Comment thread pde2e-image/README.md
Comment on lines +294 to +295
When `-appName Kaiden` (or `-repo kaiden`) is used, the runner keeps `Kaiden.exe` at
`%LOCALAPPDATA%\Programs\kaiden\` and exports `KAIDEN_BINARY` for Kaiden's Playwright CDP harness.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Clarify setup-flow requirements in the Kaiden docs.

Line 294 says -appName Kaiden or -repo kaiden, but setup-path resolution still depends on $appName ($appName.exe). Please clarify that setup installs should pass -appName Kaiden (or document that repo-only works only in non-setup/direct-path scenarios).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pde2e-image/README.md` around lines 294 - 295, The Kaiden setup docs
currently imply `-appName Kaiden` and `-repo kaiden` are interchangeable, but
the setup path logic in the runner depends on `$appName` for resolving
`$appName.exe`. Update the README section that describes setup-flow requirements
to explicitly state that setup installs must pass `-appName Kaiden` for
`KAIDEN_BINARY` to point to the expected executable, and only mention `-repo
kaiden` as valid for non-setup/direct-path scenarios if that is supported by the
runner.

@cbr7

cbr7 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

I still maintain these kind of changes need to be done in a Kaiden related fork of this repo, putting two projects in the same image/container is not a scalable solution long term.

The problem will only increase as we go forward in time and divergence between PD and Kaiden increases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants