Migrate planner bucket, plan, and tenant settings set commands to Zod#7412
Draft
waldekmastykarz wants to merge 2 commits into
Draft
Migrate planner bucket, plan, and tenant settings set commands to Zod#7412waldekmastykarz wants to merge 2 commits into
waldekmastykarz wants to merge 2 commits into
Conversation
Migrates the following commands from legacy initOptions/initValidators/ initTelemetry pattern to Zod schema validation: - planner bucket add - planner bucket get - planner bucket list - planner bucket remove - planner bucket set - planner plan add - planner plan get - planner plan list - planner plan remove - planner plan set - planner tenant settings set Closes pnp#7311 Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
MartinM85
requested changes
Jun 19, 2026
MartinM85
left a comment
MartinM85
left a comment
Contributor
There was a problem hiding this comment.
I have two small comments, nothing major. Great work @waldekmastykarz 🚀
| } | ||
| }, commandInfo); | ||
| assert.notStrictEqual(actual, true); | ||
| it('fails validation id when id and plan details are specified', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it('fails validation id when id and plan details are specified', () => { | |
| it('fails validation when id and plan details are specified', () => { |
| } | ||
| }, commandInfo); | ||
| assert.notStrictEqual(actual, true); | ||
| it('fails validation id when id and plan details are specified', () => { |
Contributor
There was a problem hiding this comment.
Suggested change
| it('fails validation id when id and plan details are specified', () => { | |
| it('fails validation when id and plan details are specified', () => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Migrates the following commands from the legacy
initOptions/initValidators/initTelemetrypattern to Zod schema validation:planner bucket addplanner bucket getplanner bucket listplanner bucket removeplanner bucket setplanner plan addplanner plan getplanner plan listplanner plan removeplanner plan setplanner tenant settings setCloses #7311
Changes
#initOptions(),#initValidators(),#initTelemetry(),#initTypes(),#initOptionSets()with exported Zodoptionsschemasschemagetter andgetRefinedSchema()for cross-field validation (option sets, conditional requirements)safeParse()for validation tests andparse()for action tests