Add NGINX Gateway Fabric compatibility#3709
Conversation
Greptile SummaryThis PR adds NGINX Gateway Fabric to the compatibility matrix, including a new scraper, a per-app YAML file, an entry in the aggregate
Confidence Score: 5/5Safe to merge — the change is data-only (new compatibility entries) plus a self-contained scraper; no application logic is modified. The generated YAML data is consistent across all three output files, the registry boundary logic is correct, and the kube-version parsing uses properly anchored regexes. The one minor robustness gap (no guard against empty kube lists in the scraper) does not affect the already-generated static data being merged. No files require special attention.
|
| Filename | Overview |
|---|---|
| utils/compatibility/scrapers/nginx-gateway-fabric.py | New scraper for NGINX Gateway Fabric; regex-based kube version parsing is correct; registry boundary logic for nginxinc/nginx org split is accurate; no warning emitted when _parse_kube_versions returns [] for an unrecognised format. |
| static/compatibilities/nginx-gateway-fabric.yaml | New per-app compatibility file; image registries correctly use ghcr.io/nginxinc for v1.x<1.6 and ghcr.io/nginx for v1.6+/v2.x; data is consistent with compatibilities.yaml. |
| static/compatibilities.yaml | Adds nginx-gateway-fabric block; content mirrors nginx-gateway-fabric.yaml; metadata and version entries are consistent. |
| static/compatibilities/manifest.yaml | Adds nginx-gateway-fabric to the manifest names list in alphabetical order; no issues. |
Reviews (3): Last reviewed commit: "Fix NGINX Gateway Fabric legacy registry" | Re-trigger Greptile
|
@greptileai review |
|
@greptileai review |
4795c6b to
25d9df3
Compare
Summary
Sources:
Test Plan
Test environment: not deployed; compatibility data-only change.
python -m py_compile utils/compatibility/scrapers/nginx-gateway-fabric.py.git diff --check.Checklist