Skip to content

feat(version): add Java version suffix to User-Agent #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gabrielpanga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(version): add Java version suffix to User-Agent #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/main/java/ai/pluggy/utils/Version.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,12 @@ public static String get() {
return VERSION;
}

/** {@code User-Agent} header value, e.g. {@code "PluggyJava/1.11.0"}. */
/**
* {@code User-Agent} header value, e.g. {@code "PluggyJava/1.11.0 (Java 1.8.0_292)"}. The Java
* version suffix gives the API visibility into the consumer's JVM.
*/
public static String userAgent() {
return "PluggyJava/" + VERSION;
return "PluggyJava/" + VERSION + " (Java " + System.getProperty("java.version") + ")";
}

private static String load() {
Expand Down
9 changes: 9 additions & 0 deletions src/test/java/ai/pluggy/utils/VersionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,13 @@ public void version_isResolvedFromFilteredProperties() {
public void userAgent_hasExpectedPrefix() {
assertTrue(Version.userAgent().startsWith("PluggyJava/"));
}

@Test
public void userAgent_includesJavaVersionSuffix() {
// e.g. "PluggyJava/1.11.0 (Java 1.8.0_292)" — gives the API visibility into the consumer's JVM.
String userAgent = Version.userAgent();
assertTrue(userAgent.startsWith("PluggyJava/" + Version.get() + " (Java "),
"userAgent should start with 'PluggyJava/<version> (Java ', got: '" + userAgent + "'");
assertTrue(userAgent.endsWith(")"), "userAgent should end with ')', got: '" + userAgent + "'");
}
}
Loading