fix(dashboard): discover experiments in flat work-dir layout#192
Open
raunaqness wants to merge 2 commits into
Open
fix(dashboard): discover experiments in flat work-dir layout#192raunaqness wants to merge 2 commits into
raunaqness wants to merge 2 commits into
Conversation
Contributor
|
Thanks for raising this! @raunaqness |
Author
|
@vaibs-d Bumped version to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Streamlit dashboard not listing experiments when using the default standalone local work directory layout.
workdir/checkpoints/directly under--work-dir(flat layout used byplexe.main)06_package_final_model) when inferring phase number and completion statusProblem
python -m plexe.main --work-dir ./plexe_workdir ...writes artifacts to:But
python -m plexe.viz --work-dir ./plexe_workdirreported "No experiments found" becausediscover_experiments()only scanned nested paths likeworkdir/{dataset_name}/checkpoints/.Reproduced after a successful end-to-end build on the Rain in Australia dataset (weatherAUS, PyPI 1.4.4, Python 3.12).
Fix
workdir/checkpoints/existsphasebefore phase/status mapping so completed runs show correctlyTest plan
poetry run pytest tests/unit/utils/dashboard/test_discovery.py -vpoetry run pytest tests/unit/ -qdiscover_experiments(Path("./plexe_workdir_clean"))returns 1 experimentpython -m plexe.viz --work-dir ./plexe_workdir_cleanlists the experiment in the sidebar