Skip to content

Use TM5 implementation of seasalt emission scheme#5

Merged
plesager merged 1 commit into
add-hamm7from
default-seasalt-emission
Jul 16, 2026
Merged

Use TM5 implementation of seasalt emission scheme#5
plesager merged 1 commit into
add-hamm7from
default-seasalt-emission

Conversation

@plesager

@plesager plesager commented Jul 16, 2026

Copy link
Copy Markdown
Owner

Switch from HAMM7 to TM5 implementation of the "Gong + SST" seasalt emissions scheme.

Summary by CodeRabbit

  • Bug Fixes
    • Corrected the default sea-salt emission setting in builds without HAMMOZ, ensuring sea-salt emissions are disabled by default.

@coderabbitai

coderabbitai Bot commented Jul 16, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The default nseasalt value for builds without HAMMOZ is changed from 8 to 0 in mo_ham.F90.

Changes

Sea-salt emission configuration

Layer / File(s) Summary
Update non-HAMMOZ default
ifs-source/arpifs/m7/module/mo_ham.F90
The non-HAMMOZ default initialization of nseasalt changes from 8 to 0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main change: switching to the TM5 sea-salt emission scheme implementation.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch default-seasalt-emission

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@plesager plesager self-assigned this Jul 16, 2026
@plesager
plesager marked this pull request as draft July 16, 2026 14:36
@plesager
plesager marked this pull request as ready for review July 16, 2026 14:37
@plesager
plesager merged commit 34719c7 into add-hamm7 Jul 16, 2026
1 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant