Declare Player as a peer dependency and adopt Player 1.0 tooling scopes#19
Open
sugarmanz wants to merge 2 commits into
Open
Declare Player as a peer dependency and adopt Player 1.0 tooling scopes#19sugarmanz wants to merge 2 commits into
sugarmanz wants to merge 2 commits into
Conversation
Convert the base plugins (@player-devtools/plugin, plugin-react, types) to declare @player-ui/* as open-ended peer dependencies (>=0.15.4) instead of pinned runtime dependencies, so consumers control the Player version. Align all @player-ui/* to >=0.15.4, migrate the deprecated @player-tools/* tooling to the new @player-cli / @player-lang / @xlr-lib scopes, and bump @devtools-ui/plugin to the 0.15 canary. Bump rules_player to v2.5.0 for parameterized DSL cli/dsl_package.
Member
Author
|
/canary |
The rules_player v2.5.0 bump activates kt ABI-check test targets that compare each library's public ABI against a checked-in golden .api file. None existed, so plugin-abi-check failed in CI. Generate the golden baselines via the -abi-update targets (messenger, plugin, basic, profiler; JVM + Android). Android dumps are empty — those libraries expose no public Kotlin ABI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts the base devtools plugins (
@player-devtools/plugin,plugin-react,types) to declare@player-ui/*as open-ended peer dependencies (>=0.15.4) instead of pinned runtime dependencies, so consumers own the Player version. Aligns all@player-ui/*to>=0.15.4, migrates the deprecated@player-tools/*tooling to the new@player-cli/@player-lang/@xlr-libscopes, bumps@devtools-ui/pluginto the 0.15 canary, and bumpsrules_playerto v2.5.0 (for the parameterized DSLcli/dsl_package).Change Type
Peer-dep conversion changes install requirements for consumers; no breaking change to the devtools API surface.
Verification
peerDependencies: >=0.15.4confirmed on the base plugins (no runtime@player-ui/*dependency)plugin-android-unit-testpasses (Maven0.15.4)0.15.5); simulator tests not exercised in this env@player-tools/*remain anywhere in the lockfileNotes
@devtools-ui/pluginis temporarily pinned to canary0.4.1--canary.62.3837(from devtools-assets PR #62). Re-pin to a stable release before merge.Release Notes
@player-ui/*as peer dependencies (>=0.15.4). Consumers must provide a compatible@player-ui/player(plusreact/types) — any version from0.15.4onward, including1.x, satisfies it.@player-tools/*scope to@player-cli,@player-lang, and@xlr-lib.📦 Published PR as canary version:
0.14.1--canary.19.1010Try this version out locally by upgrading relevant packages to 0.14.1--canary.19.1010