Update Player to 0.15.5, migrate DSL to @player-lang/react-dsl, and upgrade to Bazel 9#62
Open
sugarmanz wants to merge 4 commits into
Open
Update Player to 0.15.5, migrate DSL to @player-lang/react-dsl, and upgrade to Bazel 9#62sugarmanz wants to merge 4 commits into
sugarmanz wants to merge 4 commits into
Conversation
- Bump all @player-ui/* runtime packages 0.9.1-next.0 -> 0.15.5 (latest pre-1.0) - Replace deprecated @player-tools/dsl with @player-lang/[email protected] (its ^0.15.0 peers resolve to 0.15.5, so no @player-ui 1.x is pulled in) - Rewire all DSL imports, BUILD deps, storybook transpile map, and scaffolding templates - Reformat wrapped imports to satisfy prettier
Member
Author
|
/canary |
1 similar comment
Member
Author
|
/canary |
The coverage-trunk CI job failed with a JDK cgroup-v2 NullPointerException in
Bazel 6's Java worker (building remote_coverage_tools). Bazel 9 + the newer
bazel-docker image ship a JDK where this is fixed. Follows the same infra
upgrade already done in player-ui/player.
- .bazelversion 6.4.0 -> 9.1.1
- Bump bzlmod deps to Bazel-9-compatible versions (rules_player v2.6.6,
aspect_rules_js 2.3.8, aspect_rules_ts 3.8.10, aspect_bazel_lib 2.22.5,
bazel_skylib 1.9.0, rules_pkg 1.1.0, rules_nodejs 6.7.5, aspect_rules_swc
2.7.5); add rules_cc for the Bazel-9 CcInfo relocation
- npm_translate_lock: npm_package_target_name = "{dirname}" to match the
workspace-link target name the new js_pipeline produces (was ':pkg')
- Pin rules_ts to the repo's TypeScript (4.8.4) so the toolchain doesn't
default to TS 5.6.2 and error on deprecated tsconfig options
- Remove unused 'browser' -> esbuild-wasm/lib/browser workspace alias that the
new rules_js can't resolve (real import goes through esbuild-wasm directly)
- .bazelrc: rename deprecated experimental_remote_cache_* flags
- .circleci: bazel-docker:6 -> :latest
Local: all 32 test targets pass under Bazel 9.1.1.
sugarmanz
changed the title
Bazel 9 removed --local_cpu_resources / --local_ram_resources. CI's build:ci config hit 'Unrecognized option'. Use the Bazel 9 form --local_resources=cpu=N / --local_resources=memory=N (matches player-ui/player).
With the Bazel 9 coverage crash fixed, coverage-trunk now reaches the Codecov
upload step, which failed on the old orb's uploader GPG-key validation
('no valid OpenPGP data found'). Bump to [email protected] (matches player-ui/player)
and rename the upload param file: -> files: for the 6.x syntax.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related changes, plus the CI fixes needed to make them land green.
1. Player + DSL update
@player-ui/*(11 packages):0.9.1-next.0→0.15.5(latest pre-1.0). No@[email protected]is introduced.@player-tools/[email protected]→@player-lang/[email protected].@player-tools/dslwas renamed at Player 1.0;[email protected]declares its Player peers at^0.15.0, resolving to the same0.15.5singleton (single@player-ui/[email protected], no 1.x). Imports, BUILD deps, storybook transpile map, and scaffolding templates rewired to the new scope.2. Bazel 6 → 9 upgrade
The
coverage-trunkCI job was failing with a JDK cgroup-v2NullPointerExceptionin Bazel 6's Java worker (buildingremote_coverage_tools) — a crash before any test ran. Bazel 9 + the newerbazel-dockerimage ship a JDK where this is fixed, matching the infra upgrade already done inplayer-ui/player..bazelversion6.4.0 → 9.1.1; bzlmod deps bumped to Bazel-9-compatible versions (rules_player v2.6.6, aspect_rules_js 2.3.8, aspect_rules_ts 3.8.10, aspect_bazel_lib 2.22.5, bazel_skylib 1.9.0, rules_pkg 1.1.0, rules_nodejs 6.7.5, aspect_rules_swc 2.7.5; added rules_cc for the Bazel-9 CcInfo relocation).npm_translate_lock:npm_package_target_name = "{dirname}"to match the newjs_pipelinelink target (was:pkg).browser→esbuild-wasm/lib/browserworkspace alias the new rules_js can't resolve (real import goes throughesbuild-wasmdirectly)..circleci: executor imagebazel-docker:6→:latest.3. CI fixes uncovered by the Bazel 9 upgrade
Fixing the coverage crash let the job proceed further and surfaced two pre-existing issues that the crash had been masking:
.bazelrc: Bazel 9 removed--local_cpu_resources/--local_ram_resources→ replaced with--local_resources=cpu=N/--local_resources=memory=N. Also renamed the deprecatedexperimental_remote_cache_*flags.3.2.2→6.0.0: the old uploader's GPG key validation failed (no valid OpenPGP data found); bumped the orb and updated the upload paramfile:→files:for 6.x. Matchesplayer-ui/player.Verification
@player-ui/[email protected], zero@player-ui/*@1.x.coverage-trunk— the job that previously crashed now builds, computes, and uploads coverage end-to-end.Release Notes
Player runtime bumped to
0.15.5; DSL moved from deprecated@player-tools/dslto@player-lang/react-dsl. Build toolchain upgraded to Bazel 9.