Rewrite server test assertions. - #305
Merged
Merged
Conversation
The server Endpoint unit tests are sometimes used as a reference for how SCIM clients should issue requests, and also represents how some Jersey configurations may be set. This commit updates these tests to use AssertJ for better legibility, as well as other general cleanup. Reviewer: dougbulkley Reviewer: vyhhuang JiraIssue: DS-51690
kqarryzada
commented
Jul 17, 2026
| meta.setResourceType(resourceType.getName()); | ||
| } | ||
|
|
||
| private <T> boolean contains(Iterable<T> list, T resource) |
Collaborator
Author
There was a problem hiding this comment.
Thanks to methods like containsExactly(), we no longer need this.
dougbulkley
approved these changes
Jul 17, 2026
vyhhuang
approved these changes
Jul 17, 2026
vyhhuang
left a comment
vyhhuang
left a comment
Collaborator
There was a problem hiding this comment.
These changes look good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server Endpoint unit tests are sometimes used as a reference for how SCIM clients should issue requests, and also represents how some Jersey configurations may be set. This commit updates these tests to use AssertJ for better legibility, as well as other general cleanup.
Reviewer: dougbulkley
Reviewer: vyhhuang
JiraIssue: DS-51690