Deprecate parameters in anticipation of Jackson 3. - #296
Merged
Conversation
vyhhuang
approved these changes
Apr 24, 2026
vyhhuang
left a comment
vyhhuang
left a comment
Collaborator
There was a problem hiding this comment.
These changes look fine to me.
dougbulkley
approved these changes
Apr 24, 2026
These changes primarily focus on the MapperFactory class. In Jackson 3.x, object mappers will be read only instances. Furthermore, some class names such as "JsonParser.Feature" have been changed, so our existing methods will require upkeep to facilitate customizations. To simplify configuration management, the SCIM SDK now exposes the builder object that is used to create new object mapper instances. This stored builder instance provides more flexibility for handling configuration updates, and is an improvement over manually tracking each Jackson configuration type in our MapperFactory class. This commit also deprecates the PATCH annotation, as JAX-RS has provided an annotation for this type for many releases now. This will be removed with the upcoming Jackson 3 upgrade. Reviewer: dougbulkley Reviewer: vyhhuang JiraIssue: DS-51420
kqarryzada
force-pushed
the
DS-51420-deprecations-for-Jackson3
branch
from
April 24, 2026 21:46
b848ea2 to
a5a2506
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes primarily focus on the MapperFactory class. In Jackson 3.x, object mappers will be read only instances. Furthermore, some class names such as "JsonParser.Feature" have been changed, so our existing methods will require upkeep to facilitate customizations.
To simplify configuration management, the SCIM SDK now exposes the builder object that is used to create new object mapper instances. This stored builder instance provides more flexibility for handling configuration updates, and is an improvement over manually tracking each Jackson configuration type in our MapperFactory class.
This commit also deprecates the PATCH annotation, as JAX-RS has provided an annotation for this type for many releases now. This will be removed with the upcoming Jackson 3 upgrade.
Reviewer: dougbulkley
Reviewer: vyhhuang
JiraIssue: DS-51420