Fix unbounded cross-axis stretch crash (#48)#50
Closed
RandalSchwartz wants to merge 1 commit into
Closed
Conversation
RandalSchwartz
commented
Mar 14, 2026
RandalSchwartz
left a comment
RandalSchwartz
left a comment
Author
There was a problem hiding this comment.
Closing as this fix is included in the more comprehensive PR #51.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical crash (Issue #48) where
BoxyRoworBoxyColumnwould fail with a "BoxConstraints forces an infinite height/width" error when:SingleChildScrollViewor anotherFlexwithMainAxisSize.min).CrossAxisAlignment.stretch(which is the default for Boxy flex widgets).The fix involves checking if the incoming cross-axis constraint is finite before attempting to set a tight infinite constraint on children when stretching. This matches Flutter's
RenderFlexbehavior where it falls back to non-stretching layout in unbounded dimensions.Verified with a reproduction test case.