Skip to content

Detach the poll thread when deattach_interrupt runs on it — don't strand its stack #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gamelaster merged 1 commit into from
Jul 19, 2026
+12 −0
Merged

Detach the poll thread when deattach_interrupt runs on it — don't strand its stack #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions libpinedio-usb.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,6 +588,18 @@ int32_t pinedio_deattach_interrupt(struct pinedio_inst *inst, enum pinedio_int_p
pinedio_mutex_unlock(&inst->usb_access_mutex);
if (inst->pin_poll_thread != pthread_self())
pthread_join(inst->pin_poll_thread, NULL);
else
/* Called from within the poll thread itself (e.g. an interrupt
* callback detaching its own interrupt). We cannot join ourselves,
* but skipping reclamation entirely strands this thread's stack:
* nothing ever joins it, and the pthread_create() in the next
* pinedio_attach_interrupt() overwrites the only handle. Each
* strand permanently leaks the thread's ~8 MB stack mapping;
* callers that detach from the callback on every radio interrupt
* leak at interrupt rate (meshtastic/firmware#10468 — hundreds of
* GB of VSZ within days). Detaching ourselves instead lets glibc
* reclaim the stack when the thread exits. */
pthread_detach(pthread_self());
return 0;
}
unlock:
Expand Down