[Task]: BC Breaks for new branch strategy in master branch#29
[Task]: BC Breaks for new branch strategy in master branch#29robertSt7 wants to merge 6 commits into
Conversation
|
Where are the BC Breaks? |
|
@kingjia90 Because it cannot comment on the other PR anymore:
No, dropping support for a PHP version is not breaking, as composer just won't install it on systems with an unsupported PHP version. |
|
Ah ok, it's improper to call it bc break then, but let's keep it to highlight these "major" changes |
Removed unused interface and trait from Bundle.php.twig.
There was a problem hiding this comment.
Pull request overview
Updates the bundle generator to align with Pimcore’s new (2026.x) branch/versioning strategy and removes Admin Classic-specific bundle scaffolding.
Changes:
- Update
composer.jsonto requirepimcore/pimcore^2026.1and add abranch-aliasfordev-2026.x. - Simplify the generated bundle class template by removing
PimcoreBundleAdminClassicInterface,BundleAdminClassicTrait, and related methods.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Resources/skeleton/bundle/Bundle.php.twig |
Removes Admin Classic interface/trait and JS path registration from generated bundle classes. |
composer.json |
Bumps Pimcore dependency to the 2026.1 line and adds branch alias metadata. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.