Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

[Task]: BC Breaks for new branch strategy in master branch#29

Closed
robertSt7 wants to merge 6 commits into
2026.xfrom
newbranch-strategy-bcbreak
Closed

[Task]: BC Breaks for new branch strategy in master branch#29
robertSt7 wants to merge 6 commits into
2026.xfrom
newbranch-strategy-bcbreak

Conversation

@robertSt7

Copy link
Copy Markdown

No description provided.

@robertSt7 robertSt7 added this to the 2026.1.0 milestone Feb 27, 2026
@robertSt7 robertSt7 self-assigned this Feb 27, 2026
@jdreesen

Copy link
Copy Markdown
Contributor

Where are the BC Breaks?

@jdreesen

jdreesen commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

@kingjia90 Because it cannot comment on the other PR anymore:

Dropping PHP 8.3 alone should count as bc-break, right? But i maybe get what you are meaning, like, there is no code breaking, it's more an indirect requirement change

No, dropping support for a PHP version is not breaking, as composer just won't install it on systems with an unsupported PHP version.

@kingjia90

Copy link
Copy Markdown
Contributor

Ah ok, it's improper to call it bc break then, but let's keep it to highlight these "major" changes

Removed unused interface and trait from Bundle.php.twig.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundle generator to align with Pimcore’s new (2026.x) branch/versioning strategy and removes Admin Classic-specific bundle scaffolding.

Changes:

  • Update composer.json to require pimcore/pimcore ^2026.1 and add a branch-alias for dev-2026.x.
  • Simplify the generated bundle class template by removing PimcoreBundleAdminClassicInterface, BundleAdminClassicTrait, and related methods.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/Resources/skeleton/bundle/Bundle.php.twig Removes Admin Classic interface/trait and JS path registration from generated bundle classes.
composer.json Bumps Pimcore dependency to the 2026.1 line and adds branch alias metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Resources/skeleton/bundle/Bundle.php.twig
Comment thread composer.json
Comment thread composer.json
@herbertroth
herbertroth deleted the branch 2026.x March 24, 2026 14:48
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants