Abstract localStorage interactions into a custom Hook#135
Open
Agnish1611 wants to merge 1 commit into
Open
Conversation
Agnish1611
requested review from
Arindam-at-Pieces,
mason-at-pieces and
shivaypiece
as code owners
July 17, 2024 12:07
Contributor
|
Hey @Agnish1611 , this issue is already being worked on #130 , However, I would recommend that you collaborate there and probably review that PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR creates a custom Hook called useOsVersion to abstract the localStorage interactions. The logic for accessing and updating the OS version has been encapsulated into this hook #125
Changes
src/app/components/Indicator/useOsVersion.tsxwhich exports the custom useOsVersion hook with three states:osVersion: variable which stores the version from the localStorageupdateOsVersion: function which updates the OS version in the localStorageerror: variable which stores the error message in case some error occured while accessing or updating the OS versionisQuotaExceededErrorfunction