ci: strip bundled libwayland from AppImage via pickforge-tauri-release#29
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bc3e1664c2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| TAURI_SIGNING_PRIVATE_KEY_PASSWORD: ${{ secrets.TAURI_SIGNING_PRIVATE_KEY_PASSWORD }} | ||
| run: | | ||
| shopt -s nullglob | ||
| appimages=(src-tauri/target/release/bundle/appimage/*.AppImage) |
There was a problem hiding this comment.
In this repo src-tauri is a Cargo workspace member (Cargo.toml lists members = [".", "src-tauri"]), so Tauri/Cargo writes release bundles under the workspace target/release/bundle, which is also the artifact root configured in pickforge.release.json. This new glob scans src-tauri/target/..., so a normal tagged release will find zero AppImages and exit before asset collection/upload. Use the workspace path (target/release/bundle/appimage/*.AppImage) or derive it from the release config.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in acf0649 — the glob now scans the workspace-root target/release/bundle, matching pickforge.release.json's artifactRoot.
|
@codex review |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Adopts the shared
fix-appimagecommand from @pickforge/tauri-release 0.3.0: after the Tauri build, the AppImage gets libwayland stripped, repacked, verified, and re-signed before asset collection — same fix pickforge/pickgauge ship, previously missing here.Tested:
validate-configpasses with 0.3.0 installed; workflow YAML validated; the shared command is proven against real PickForge production AppImages (stripped 4 libs from v0.1.7, idempotent on v0.1.9). Real proof lands with the next tagged release.Closes #22
Refs pickforge/pickforge-platform#9