ci: cache Rust builds in release workflow#32
Conversation
Tagged releases compiled the full workspace from scratch on every platform (v0.1.2 run: 22 min). Swatinem/rust-cache@v2 mirrors ci.yml and pickscribe's release workflow. Refs #30
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f539c79ee4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Set up Rust | ||
| uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - uses: Swatinem/rust-cache@v2 |
There was a problem hiding this comment.
Because this repo's only Cargo manifest is under src-tauri (the existing CI workflow configures workspaces: src-tauri for the same action), leaving Swatinem/rust-cache on its default workspace . makes it invoke Cargo metadata from the repo root. I verified cargo metadata --all-features --format-version 1 --no-deps from /workspace/pickgauge exits 101 with could not find Cargo.toml, so tagged/manual release builds will fail at this step before bundling; add with: workspaces: src-tauri here.
Useful? React with 👍 / 👎.
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Tagged releases compiled the full Rust workspace from scratch on every platform (v0.1.2 release run: 22 min). This adds
Swatinem/rust-cache@v2to the release build matrix, mirroring ci.yml (which already caches) and pickscribe's release workflow (which releases in 5–10 min with it).Tested: YAML parse check.
Not tested yet: proves out on the next two tagged releases (first populates the cache, second hits it).
Risk: low — a cache miss just means today's from-scratch speed.
Release tracking: noted under Internal/release changes in
docs/releases/UNRELEASED.md.Closes #30
Part of the agent-DX batch: pickforge/pickforge-platform#19