[codex] Use plain IN for single WordPress identity fields#29
Closed
alexstandiford wants to merge 1 commit into
Closed
[codex] Use plain IN for single WordPress identity fields#29alexstandiford wants to merge 1 commit into
alexstandiford wants to merge 1 commit into
Conversation
Contributor
Author
|
Closing this because it only makes the single-field IN query shape more WordPress-like. It is not proven to fix the intermittent create/readback failure and should not be represented as the root-cause fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INclauses for single identity-field lookups in the WordPress clause builder.INSQL for true compound identity fields.Why
WordPress fetches records such as posts with a direct primary-key predicate (
WHERE ID = %d LIMIT 1). PHPNomad's WordPress integration was generating row-constructor SQL even for a single identity field, e.g.(alias.id) IN ((%s)). This keeps the PHPNomad API unchanged while making the WordPress integration emit the simpler primary-key lookup shape WordPress itself uses for single-column identities.Validation
vendor/bin/phpunit --filter ClauseBuilderTest --testdoxvendor/bin/phpunit --testdox