Require patched Guzzle and PSR-7 versions#437
Open
GrahamCampbell wants to merge 1 commit into
Open
Conversation
Member
|
Well, it would break the backward compatibility, so we should do this only when a new major version is released |
Contributor
Author
|
I don't agree. Moreover, allowing PSR-7 v3 would cause real issues. If people really want to use super old insecure code, composer will still let them do it by resolving an older version of your library, or by pretending their older version of guzzle is a newer version using the |
Contributor
Author
|
It is very common for people to bump versions of dependencies in patch and minor releases across the PHP ecosystem, both among packages that claim they follow semver, but do a bad job, and those that actually follow it well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security hardening. Versions that exist before
GuzzleHttp\Psr7\Utilshave CVEs published for them, and our PSR-7 v3 library will have breaking changes, so you will want to control when the upgrade to that is allowed.