Render leading span marker with nothing to merge as an empty cell#245
Merged
Conversation
A colspan marker (`<`) in the first column has no cell to its left, and a rowspan marker (`^`) in the first row has no cell above. Such a marker has nothing to merge into, so it was silently dropped, leaving the row one cell short. It now renders as an empty cell instead, matching djot-js / carve parity. Leftover colspan accumulation after the reverse merge loop is flushed into empty leading cells. A rowspan marker that finds no originating cell above becomes an empty cell rather than a dangling marker.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #245 +/- ##
=========================================
Coverage 92.05% 92.06%
- Complexity 3566 3571 +5
=========================================
Files 107 107
Lines 10093 10118 +25
=========================================
+ Hits 9291 9315 +24
- Misses 802 803 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A leading span marker with nothing to merge should render an empty cell, not vanish.
A colspan marker (
<) in the first column has no cell to its left, and a rowspan marker (^) in the first row has no cell above. In both cases the marker has nothing to merge into, so previously it was silently dropped and the row ended up one cell short. It now renders as an empty cell instead, matching djot-js / carve parity. Normal spans into an existing left/above cell are unchanged.Ported from carve-php commit ff40264 (table part only).