refactor(runtime): make tool launches clockless#268
Merged
Conversation
Signed-off-by: phoxal-release-bot <[email protected]>
Open
21 tasks
Signed-off-by: phoxal-release-bot <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs phoxal/.github#39
Summary
#[phoxal::tool]a clockless type-level launch policy: tool binaries expose neither--clocknor--simulation, ignorePHOXAL_CLOCK, and cannot opt into logical-time executiondefault.wbtworld with 1 m wallsWhy
Tools represent external devices, operator input, networking, and host diagnostics. They do not own robot state transitions and therefore must not join the robot logical clock or Webots step barrier. The previous generic runner and launch surfaces exposed clock selection to every participant and required a runtime
participant == "tool"branch to repair that mismatch.The boundary is now encoded by the participant macro and launch-policy type. Runner code selects behavior through that policy, with no string-based tool special case.
Validation
cargo test --workspace --quietcargo clippy --workspace --all-targets -- -D warningscargo fmt --all -- --checkgit diff --checkphoxal-tool-telemetry --help: no clock flag or environment binding--clock simulationand--simulationexamples/hello-rover/worlds/default.wbtheadlessly with the 1 m wallsReview
Independent cross-review found a potential bypass through the public graph marker. The deterministic clock seam now additionally requires
LaunchPolicy = ClockedParticipantLaunch, and the compile-fail test proves a tool cannot bypass that by manually implementing the marker. The reviewer rechecked the fix and found no remaining code blocker. The one stale API-doc sentence found on the final pass was corrected before commit12ef9f7.Delivery order
This is the contract-owning framework change. After merge and the framework release/catalog completes, the CLI follow-up removes obsolete simulation-clock configuration for standard tools and runs mode-parity/clean-room validation. Organization documentation reconciliation follows last.