Improve ReEquivalentSuperclassMethodsRule - #19885
Open
jecisc wants to merge 1 commit into
Open
Conversation
Member
Author
|
I've done this PR to p14 because this is kinda a bugfix. But since it is not really important, maybe it should go to p15? I don't have a strong opinion on this |
Member
|
I would merge it in P15 :) Thanks for your free time contribution. |
Member
|
If I look a the PR Change, This shows lot of changes that are not related to this PR. Is that good ? Or did that un-do changes in Pharo 15? |
MarcusDenker
added
the
Status: Need more work
Member
Author
|
Since the base changed, it bring what was merged in P14 before my PR to P15. If we merge P14 in P15 we will have only my changes appearing |
Member
|
So what should we do? It is reasonable to merge P14 in P15 I thought so. But I prefer to ask. |
This rule was considering methods from traits, but it really depends on the context. I propose to skip methods from traits when we look for methods with an equivalent in super classes since traits do not have a superclass by construction. *Done on my free time*
jecisc
force-pushed
the
misc/improve-rule
branch
from
August 14, 2026 18:20
4defcb9 to
fc5679a
Compare
Member
Author
|
I updated the PR to contain only my change and avoid a mess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This rule was considering methods from traits, but it really depends on the context. I propose to skip methods from traits when we look for methods with an equivalent in super classes since traits do not have a superclass by construction.
Done on my free time