Remove ReExcessiveMethodsRule - #19866
Open
jecisc wants to merge 1 commit into
Open
Conversation
It seems that this rule is not good because smalltalk encourage to have small methods. But how can we have small methods if we are limited in the number of methods? This seems to be the result of the discussion on this issue: pharo-project#19815 So I'm proposing to remove this rule. I'm opening a PR to propose this change and now I'm letting the community comment about merging it or closing it depending on what we want
Member
|
What would be nice is to compute the average # of methods of the package and flag the 20% that are above that value. Because 60 is not a good idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that this rule is not good because smalltalk encourage to have small methods. But how can we have small methods if we are limited in the number of methods?
This seems to be the result of the discussion on this issue: #19815
So I'm proposing to remove this rule. I'm opening a PR to propose this change and now I'm letting the community comment about merging it or closing it depending on what we want
Fixes #19815